]> dgit.raspbian.org Git - gnome-shell.git/commit
keyboard: Disconnect from input source manager when destroying indicator
authorPhilip Withnall <withnall@endlessm.com>
Fri, 18 Jan 2019 13:23:36 +0000 (13:23 +0000)
committerFlorian Müllner <florian.muellner@gmail.com>
Thu, 24 Jan 2019 14:48:48 +0000 (14:48 +0000)
commit8bb9eb0fc9d45380823896fd5ae8f9340cdc31ea
treeb8eb95a197dee112f4527e2958170e073c975370
parent21de3c327b9e5f4141723c15e75e52c206e71b53
keyboard: Disconnect from input source manager when destroying indicator

When an InputSourceIndicator is destroyed, the InputSourceManager it was
connected to could (and probably will) outlive it (since the manager is
a singleton). If the InputSourceManager emits any subsequent signals,
the callbacks from the finalised InputSourceIndicator could be invoked,
and will reference finalised objects.

This can be triggered by running `pkexec true` from a gnome-terminal
window, then calling `pkill pkexec` from another terminal (on a
different VT or via SSH). This causes the dialogue to be cancelled by
polkitd.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/357
js/ui/status/keyboard.js